[Bug 182306] Review Request: dogtail - GUI test tool and automation framework

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: dogtail - GUI test tool and automation framework


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=182306


toshio at tiki-lounge.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163778                      |163779
              nThis|                            |




------- Additional Comments From toshio at tiki-lounge.com  2006-03-26 13:35 EST -------
APPROVED

81b987b1f18f1741d87f937877a4b071  dogtail-0.5.1-2.src.rpm

One note:  Do you have an automated script that you use to build the packages? 
Because the dogtail-0.5.1.tar.gz file has changed between releases.  I checked,
though, and the changes between the two are just the changes to the spec file.

Modifying the upstream tarball without changing the release number is not a
great idea as it leads to slightly different packages in different distributions
and prevents reviewers from doing a simple md5sum to check that the upstream
sources are valid.  In this case, the changes are small and well known so it's
not a big deal.  Something to keep in mind for the future, though.

Everything important is fixed in this release and it still builds in mock and
runs.  The only thing I noticed is that the URL field now points at:: 
  http://people.redhat.com/zcerza/dogtail/releases/
instead of the webpage::
  http://people.redhat.com/zcerza/dogtail/

This is a minor issue.  No need to respin and re-review.  Just something you'll
want to change after you import the package into CVS and before pushing through
the buildsystem.

You're ready for Step 8::
  http://www.fedoraproject.org/wiki/Extras/NewPackageProcess

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.