Re: Good Review Examples?

[Matthias Saou <thias spam spam spam spam spam spam spam egg and spam freshrpms net>]

Warren Togami wrote :

> http://fedoraproject.org/wiki/Extras/Contributors
> Under the "Read Other Submissions" section, I think we should have a few 
> links to exemplary examples of how a package review should look like.
> 
> What are the elements of a good review example?
> 
> * Well formed submission as suggested by the template.
> * Constructive comments describing how the package can be improved.
> * Possibly some back and forth.
> * APPROVED
> * Properly formed fedora-cvs request
> * done
> 
> Any good examples from recent review tickets?

Are you interested in counter-examples too? It's not a formal review,
but IMHO definitely highlights some of the possible misunderstandings
people can have from the guidelines :
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=230096

- No constructive comments, just "MUST" (some wrong) and "SHOULD"
- No indication of it's formal or just some preliminary comments

Matthias

-- 
Clean custom Red Hat Linux rpm packages : http://freshrpms.net/
Fedora Core release 6 (Zod) - Linux kernel 2.6.19-1.2895.fc6
Load : 0.62 0.43 0.22