Re: rpms/gnome-sudoku/FC-6 .cvsignore, 1.4, 1.5 gnome-sudoku.spec, 1.12, 1.13 sources, 1.4, 1.5

["Peter Gordon" <peter thecodergeek com>]

Paul W. Frields wrote:
[...]
> +#%{__python} setup.py install -O1 --skip-build --root $RPM_BUILD_ROOT
> +%makeinstall

Eeewwww.. :[ Please use 'make install DESTDIR=$RPM_BUILD_ROOT' instead of
the broken %makeinstall invocation. See Packaging/Guidelines#MakeInstall on
the wiki for more information. [1]

>[...]
>  %dir %{_datadir}/%{name}/
> -%{_datadir}/%{name}/*
> +%{_datadir}/%{name}/

This one means that %{_datadir}/%{name} is listed twice as an owned directory:
once in the %dir macro, and another time in the files listing itself. Please
remove the %dir line in that case. :)

[1] http://fedoraproject.org/wiki/Packaging/Guidelines#MakeInstall

Thanks.
-- 
Peter Gordon (codergeek42)
This message was sent through a webmail
    interface, and thus not signed.