Re: rpms/perl-Test-Distribution/devel perl-Test-Distribution.spec, 1.2, 1.3

[Ville Skyttä <ville skytta iki fi>]

On Thursday 01 March 2007, Chris Weyl wrote:
> @@ -49,7 +49,7 @@
>
>  %check
>  # these will cause problems otherwise...
> -rm debug*list
> +rm -f debug*list
>
>  ./Build test
>
> @@ -63,6 +63,9 @@
>  %{_mandir}/man3/*
>
>  %changelog
> +* Thu Mar 01 2007 Chris Weyl <cweyl alumni drew edu> 1.26-3
> +- cause rm to not fail on non-existance of debug*list in check.

Looks like this was done in order to appease Module::Signature checks.  
However, it's better to not run Module::Signature tests at all if they're 
sanely avoidable, or if that fails, run them with special settings in order 
to avoid it silently importing GPG keys into the build user's keyring.  More 
info (also linked to from the Perl SIG Wiki page):

http://koti.welho.com/vskytta/packagers-handbook/packagers-handbook.html#guidelines-perl-cpansign

Disabling the signature test doesn't seem to be easy with this package so the 
network access problem remains, but the attached patch would fix the problem 
with build user GPG keyring trashing.  (The disabling debuginfo vs rm -f 
debug*.list part is only cosmetic.)

Index: perl-Test-Distribution.spec
===================================================================
RCS file: /cvs/extras/rpms/perl-Test-Distribution/devel/perl-Test-Distribution.spec,v
retrieving revision 1.3
diff -u -r1.3 perl-Test-Distribution.spec
--- perl-Test-Distribution.spec	1 Mar 2007 19:49:05 -0000	1.3
+++ perl-Test-Distribution.spec	1 Mar 2007 21:48:38 -0000
@@ -1,3 +1,6 @@
+# noarch, but to avoid debug*.list interfering with signature/manifest tests:
+%define debug_package %{nil}
+
 Name:           perl-Test-Distribution
 Version:        1.26
 Release:        3%{?dist}
@@ -48,10 +51,9 @@
 %{_fixperms} %{buildroot}/*
 
 %check
-# these will cause problems otherwise...
-rm -f debug*list
-
-./Build test
+tmpdir=$(mktemp -d %{_tmppath}/%{name}-%{version}-%{release}.XXXXXX)
+mkdir -m 700 $tmpdir/_gnupg ; export GNUPGHOME=$tmpdir/_gnupg
+./Build test && rm -rf $tmpdir
 
 %clean
 rm -rf %{buildroot}