Re: Kernel package status

[Michal Jaegermann <michal harddata com>]

On Tue, Jun 22, 2004 at 11:16:29PM -0400, Marc Deslauriers wrote:
> On Tue, 2004-06-22 at 20:44, Michal Jaegermann wrote:
> > Possibly not a very critical bug (I do not know that really)
> > but a bug nevertheless.  It does not look that regs.len is
> > used very extensively.  Presumably it is set in a preceding
> > copy_from_user() call and not used really in any other place.
> 
> Ethtool is expecting bytes there, so it looks to me that the revised
> patch is necessary for "ethtool -d" to return correct data...
> 
> What do you think, Michal?

Yes, that I think I wrote. :-)  Does not matter if
E1000_REGS_LEN * sizeof(uint32_t) or sizeof(regs_buff) is used
this comes to the same thing.   Which way this is done is a matter
of taste.  The real point is that copy_{from,to}_user() functions
expect a size argument in bytes.

   Michal