[Bug 204258] Review Request: mousepad - A simple text editor for Xfce

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: mousepad - A simple text editor for Xfce


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=204258


fedora at christoph-wickert.de changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163778                      |163779
              nThis|                            |




------- Additional Comments From fedora at christoph-wickert.de  2006-09-02 19:54 EST -------
REVIEW for
3e94740de010b2285fc8711336538fe6  mousepad-0.2.6-2.fc6.src.rpm

MUST items:
OK - rpmlint quite on all packages
OK - package meets naming guidelines
OK - spec file meets naming guidelines
OK - package meets package guidelines
OK - license open-source compatible (GPL)
OK - license in specfile matches actual license
OK - license included in %doc
OK - spec file in American English
OK - spec file is legible
OK - source in SRPM matches upstream source (md5 f8c23b1de6d23927729c477689883c38)
OK - package builds on i386
OK - all build dependencies listed BuildRequires
OK - none of the exceptions of packaging guidelines in BuildRequires
OK - locales handled correctly with %find_lang
OK - no shared libs
OK - package is not relocatable
OK - package owns all directories that it creates
OK - no duplicate files in %files section
OK - permissions and %defattr correct 
OK - clean section with "rm -rf $RPM_BUILD_ROOT" present
OK - macro usage consistent
OK - code, not content
OK - no large docs
OK - docs don't affect runtime
OK - no headers or static libs
OK - no pkgconfig files
OK - no libtool archives
OK - mousepad.desktop included and correctly installed
OK - package doesn't own files/directories owned by other packages

SHOULD items:
OK - package builds in mock (Core 5 and 6)
OK - package functions as described
OK - mime type correctly installed with scriptlet from wiki
OK - package uses disttag


APPROVED


Note: Don't forget
 Requires(post): desktop-file-utils
 Requires(postun): desktop-file-utils
if you are planning to build this for Core 4

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.