[Bug 205041] Review Request: tellico - collection manager

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: tellico - collection manager


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=205041





------- Additional Comments From jamatos at fc.up.pt  2006-09-03 13:37 EST -------
(In reply to comment #1)
> 
> 1. In your desktop-file-install you have --vendor="", but according
> to guidelines that should be --vendor=fedora. Also, this causes
> builds under mock to fail because the fedora-tellio.desktop file doesn't
> exist.

  As you can guess, I had that. I hesitated because the desktop files is 
included in the project. I will revert that to vendor fedora.

> 2. INSTALL NEWS README can probibly all be dropped. INSTALL is the generic
> auto* install document, NEWS and README are both of size 0.

  You are right. Done.
 
> 3. The Summary is a bit generic:
> Summary:        collection manager
> Perhaps at least add that it's a KDE based collection manager?

  Honestly I don't like to to label a program based on the framework used. 
That can be seen from its dependencies. This is build with kde and not needed 
or used by kde. It is interesting even if kde is not used... although it will 
require the dependencies to be satisfied.

> 4. rpmlint says:
> W: tellico summary-not-capitalized collection manager
> So, it should at least be "A KDE collection manager"

  I changed that to "A collection manager". If you insist I can add there the 
KDE word though, I am not dogmatic about it. :-)

Spec URL: http://www.fc.up.pt/pessoas/jamatos/fedora-extras/tellico.spec
SRPM URL: 
http://www.fc.up.pt/pessoas/jamatos/fedora-extras/tellico-1.2-2.src.rpm



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.