[Bug 204228] Review Request: sleuthkit - Open Source forensic toolkit

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: sleuthkit - Open Source forensic toolkit


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=204228





------- Additional Comments From fedora-devel at mx-solutions.de  2006-09-04 05:13 EST -------
(In reply to comment #2)
> * The Packager & Vendor tags should not be included, nor refer to the Dag Wieers
> repository. Please remove them.
Yes i remove.
> 
> * The %setup macro is better invoked with the -q arg since there is no need to
> pollute build output with a list of files being extracted from the tar.gz
Ok, will fix it.
> 
> * The build process in the package is not honouring the $RPM_OPTS_FLAGS compiler
> settings. For example - its compiling with -O -g :
> 
> gcc -DLINUX2 -D_FILE_OFFSET_BITS=64 -D_LARGEFILE64_SOURCE -DVER=\"2.05\"
> -I../auxtools -I../imgtools -O -Wall  -g   -c -o jcat.o jcat.c
> 
> While current Fedora build flags are:
> 
>  -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector
> --param=ssp-buffer-size=4
> 
> It would be very desirable to have the build process honour these options since
> they enable various security protection measures. A cursory look at the source
> code suggests it would probably need a patch applied to the Makefiles since they
> are hand-written instead of using AutoTools. IMHO, such a patch would be
> worthwhile, unless there are specific problems compiling the tools with these
flags.
> 
I have tried with the standard flags but it seems that the -j3 is the problem.
How i can filter it out?

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.