[Bug 205023] Review Request: filelight-1.0 - cool diskspace use browser for kde

bugzilla at redhat.com bugzilla at redhat.com
Tue Sep 5 11:56:14 UTC 2006


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: filelight-1.0 - cool diskspace use browser for kde


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=205023





------- Additional Comments From panemade at gmail.com  2006-09-05 07:56 EST -------
More to do in SPEC
Add %{?dist} to Release tag
Release: 2%{?dist}

Remove macros used in %chnagelog section otherwise rpmlint on src.rpm will NOT
be silent
I: filelight checking
W: filelight macro-in-%changelog files
Macros are expanded in %changelog too, which can in unfortunate cases lead
to the package not building at all, or other subtle unexpected conditions that
affect the build.  Even when that doesn't happen, the expansion results in
possibly "rewriting history" on subsequent package revisions and generally
odd entries eg. in source rpms, which is rarely wanted.  Avoid use of macros
in %changelog altogether, or use two '%'s to escape them, like '%%foo'.

W: filelight macro-in-%changelog _sysconfdir
Macros are expanded in %changelog too, which can in unfortunate cases lead
to the package not building at all, or other subtle unexpected conditions that
affect the build.  Even when that doesn't happen, the expansion results in
possibly "rewriting history" on subsequent package revisions and generally
odd entries eg. in source rpms, which is rarely wanted.  Avoid use of macros
in %changelog altogether, or use two '%'s to escape them, like '%%foo'.

On Binary RPM rpmlint is silent

Still desktop file is not handled properly
add --delete-original option to desktop-file-install
what is second filelight_part.desktop ?

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.




More information about the Fedora-package-review mailing list