[Bug 187294] Review Request: gwyddion

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gwyddion


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=187294





------- Additional Comments From yeti at physics.muni.cz  2006-09-07 15:42 EST -------
(In reply to comment #13)

Part I: Fixed stuff.

Spec URI: http://gwyddion.net/download/test/gwyddion.spec
SRPM URI: http://gwyddion.net/download/test/gwyddion-1.99.9-2.src.rpm

* Thu Sep 07 2006 David Necas (Yeti) <yeti at physics.muni.cz> - 1.99.9-2
- Removed `remove shbangs from modules', not needed anymore
- Fixed requirements of devel subpackage: require libs, not main; require
  pkgconfig; added missing gtkglext-devel (required since we build with it)
- Don't own %%{_libdir}/pkgconfig directory
- Avoided automated Provides: perl(Gwyddion::dump)
- Moved ldconfig execution to libs subpackage scriptlet
- Added desktop, MIME database handling scriptlets from Fedora wiki
- Patch ltmain.sh instead of ex-post .la file removal (taken from FreeBSD port)

> gwyddion-devel shouldn't own %{_libdir}/pkgconfig, but instead
> Requires: pkgconfig

Fixed.

> The shebangs removal seems to be done now, so the following is certainly
> not relevant anymore (as said in the comment ;-):
> # Remove shbangs from modules (upstream 1.99.8 will fix that)
> sed -i '1s/^#!.*//' ruby/gwyddion/dump.rb python/Gwyddion/dump.py

Fixed.

> For the desktop file you should have a look at:
>
http://fedoraproject.org/wiki/Packaging/Guidelines#head-254ddf07aae20a23ced8cecc219d8f73926e9755

Hopefully fixed.

> There is something very strange, an include file below %_libdir:
> /usr/lib/gwyddion/include/gwyconfig.h
> I guess it is there because it is a generated include file so it 
> could include some platform-dependant informations... I have seen
> that other libraries do the same, so I guess it is ok.

Yes, it is a page taken from GLib book and it is there exactly for
this reason, although it currently contains no *architecture*-dependent
bits.  But one should be able to install for example 32bits
gwyddion libs with GtkGLExt enabled and 64bit with GtkGLExt disabled
(not that concerns Fedora much but it explains the file).

> Since the perl module is an internal module, the man page should
> certainly not be shipped, and the automatically determined
> Provides perl(Gwyddion::dump) should not be present
> 
> Removing the provides may be achieved by
> %define __perl_provides %{nil}

Fixed.

> I am not convinced that the -devel package should require the base package,
> if plugin examples are removed.
> but it should certainly require the libs package, so I propose changing  
> Requires:      %{name} = %{version}
> to 
> Requires:      %{name}-libs = %{version}-%{release}

Fixed.

> The %post/%postun should be for the libs subpackage and not the main package.

Fixed.

> There are %post scriptlets missing for mime handling, you should have
> a look at
>
http://fedoraproject.org/wiki/Packaging/ScriptletSnippets?action=show&redirect=ScriptletSnippets#head-de6770dd9867fcd085a73a4700f6bcd0d10294ef
> and
>
http://fedoraproject.org/wiki/Packaging/ScriptletSnippets?action=show&redirect=ScriptletSnippets#head-5f93ed83c968bb73b052c06ba0d7139e28f35d93

Hopefully fixed.



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.