[Bug 193897] Review Request: mysql-connector-java - Official JDBC driver for MySQL

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: mysql-connector-java - Official JDBC driver for MySQL


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193897





------- Additional Comments From green at redhat.com  2006-09-08 14:26 EST -------
One final thing and this is APPROVED.  See the line starting in 'X'.

Also, why are you packaging version 3.1.12 when the most recent version is
5something.  We normally require that the most recent version be packaged.


* package meets and packaging guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
X dist tag is not present.  Add %{?dist} to Release tag.
* build root is correct. 
* license field matches the actual license.
* license is open source-compatible.
* License text included in package.
* source files match upstream (although they are modified to remove binary jars.
 upstream makes no source only release).
? latest version is not being packaged. Upstream is at version 5.  Why aren't we
packaging version 5?
* BuildRequires are proper.
* package builds in mock.
* rpmlint is silent.
* final provides and requires are sane
mysql-connector-java-3.1.12-1jpp_4fc.i386.rpm
=========
  mm.mysql
  mysql-connector-java-3.1.12.jar.so
  mysql-connector-java = 1:3.1.12-1jpp_4fc
  =
  java-gcj-compat >= 1.0.31
  jta >= 1.0
  log4j
* shared libraries are present, but no ldconfig required.
* package is not relocatable.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* %clean is present.
* %check is not present
* scriptlets OK
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no libtool .la droppings.
* not a GUI app (no .desktop file required).
* not a web app.



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.