[Bug 205023] Review Request: filelight-1.0 - cool diskspace use browser for kde

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: filelight-1.0 - cool diskspace use browser for kde


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=205023


j.w.r.degoede at hhs.nl changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|rdieter at math.unl.edu        |j.w.r.degoede at hhs.nl
OtherBugsDependingO|                            |177841
              nThis|                            |




------- Additional Comments From j.w.r.degoede at hhs.nl  2006-09-09 05:27 EST -------
Rex,

Sorry for hijacking this review, but Neal needs a sponsor (and forgot to set the
FE_NEEDSPONSOR flag on this) and I'm currently in the process of sponsering him.

Also I know /realize that you know much more about KDE then may so feel free to
jump in.


MUST:
=====
* rpmlint output is:
E: filelight file-in-usr-marked-as-conffile /usr/share/config/filelightrc
W: filelight conffile-without-noreplace-flag /usr/share/config/filelightrc
This is normal for KDE packages and can both be ignored
* Package and spec file named appropriately
* Packaged according to packaging guidelines
* License GPL ok and included
* spec file is legible and in Am. English.
* Source matches upstream
* Compiles and builds on devel x86_64
0 BR, some are redundant see must fix
0 No locales, but still %find_lang is used, remove it!
* No shared libraries
* Not relocatable
* Package owns / or requires all dirs
* No duplicate files & Permissions ok
* %clean & macro usage OK
* Contains code only
* %doc does not affect runtime, and isn't large enough to warrent a sub package
* no -devel package needed, no libs
* .la files, but this is ok (KDE exception)
O .desktop file as required, but not properly installed


Must Fix
========
* Drop the "Vendor: Dag Apt Repository, http://dag.wieers.com/apt/" line
* The qt-devel BR is redundant and should be removed as kdelibs-devel already
  requires it
* Drop this line "%find_lang %{name} || touch %{name}.lang" I don't see a 
  -f arg to %files, so clearly this is not needed
* Use desktop-file-install as documented in the Scriptles page of the wiki,
  this is in the review guidelines! If you disagree with the scriptlet page 
  discuss this on the extras mailing list instead of deviating on your own.
* You install files under /usr/share/icons, you must add the nescesarry post 
  postun scriptlets to update the icon-cache, and please use the scriplets 
  exactly as documented. Again if you (or Rex) disagree discuss this on the 
  list.
* You install files under /usr/share/icons/hicolor, so you must Require
  hicolor-icon-theme, which is the "filesystem" equivalent for the 
  /usr/share/icons/hicolor dir hierarchy (I just learned this myself recently)


Should Fix
==========
* Drop the following lines:
# $Id$
# Authority: dag
# Upstream: Max Howell <filelight$methylblue,com>
* "%defattr(-, root, root, 0755)" the FE default for this is
  "%defattr(-,root,root,-)"


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.