[Bug 201674] Review Request: codeblocks

bugzilla at redhat.com bugzilla at redhat.com
Tue Sep 12 16:27:40 UTC 2006


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: codeblocks


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=201674


tibbs at math.uh.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163778                      |163779
              nThis|                            |




------- Additional Comments From tibbs at math.uh.edu  2006-09-12 12:27 EST -------
You should use "svn export" instead of "svn co" to generate your tarballs.  The
.svn directories are useless in this context.  Deleting all of the .svn
directories from the tarball gives me a clean compare except for one file:

diff -ur a/codeblocks/src/plugins/contrib/help_plugin/help_plugin.cpp
b/codeblocks/src/plugins/contrib/help_plugin/help_plugin.cpp
--- a/codeblocks/src/plugins/contrib/help_plugin/help_plugin.cpp       
2006-08-19 04:03:12.000000000 -0500
+++ b/codeblocks/src/plugins/contrib/help_plugin/help_plugin.cpp       
2006-08-18 10:24:58.000000000 -0500
@@ -20,7 +20,7 @@
 * Program URL   : http://www.codeblocks.org
 *
 * $Id: help_plugin.cpp 2875 2006-08-18 15:24:58Z thomasdenk $
-* $Date: 2006-08-18 17:24:58 +0200 (Pá, 18 srp 2006) $
+* $Date: 2006-08-18 10:24:58 -0500 (Fri, 18 Aug 2006) $
 */

 #include "help_plugin.h"

I guess you'd have to set LANG and TZ when checking out as well.  Or perhaps
there's a flag to svn that could be used to suppress that kind of expansion.  In
any case, this isn't a big deal although when the time comes to check this
package in, you should use a tarball generated with "svn export" to get rid of
the needless ".svn" directories.

The %configure line looks much simpler now.

/usr/lib64/codeblocks is properly owned now.

The desktop file looks to be properly installed.  I recall that Rex is trying to
get changes made to the desktop file policy with regards to using "--vendor
fedora" but at this point I don't know what the fuss is about and what you have
done is in accordance with the current packaging guidelines.

So all of the issues I had are fixed; just be sure to get rid of those .svn
directories in your tarball.

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.




More information about the Fedora-package-review mailing list