[Bug 199029] Review Request: jokosher

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: jokosher


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199029





------- Additional Comments From toshio at tiki-lounge.com  2006-09-19 17:26 EST -------
The SOURCE1 isn't a binary.  It's a script.  I can see why you're doing that but
it is kinda ugly.  What's upstream's plans for future releases?  Will they
include that kind of script?  Or make it so Jokosher.py actually can be 
installed to %{bindir}?  Or....?

__init__.py might be better as:
touch %{buildroot}%{python-sitelib}/%{name}/__init__.py

but you have a comment in your changelog about security.  Can you explain if
touch would be a problem?

Putting the png images into %{python-sitelib} isn't a great idea.  Is it hard to
put them into %{_datadir}/%{name} or something similar?

If you use your jokosher script you probably don't want execute permissions on
Jokosher.py.

I'm not sure about the wisdom of making WaveForm.py exectuable.  It loks to me
as though directly executing WaveForm.py makes a test case run... so this isn't
something someone who installs jokosher is going to want to do.  (Correct me if
I'm wrong on that.)

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.