[Bug 205057] Review Request: dx-samples - OpenDX Examples

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: dx-samples - OpenDX Examples


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=205057


paul at all-the-johnsons.co.uk changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163778                      |163779
              nThis|                            |

rpm at greysector.net changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |NEXTRELEASE




------- Additional Comments From paul at all-the-johnsons.co.uk  2006-09-19 16:46 EST -------
Review

License good
Upstream and source tarballs md5sums match
Spec in UTF-8, US English and is readable
Mock is happy as is rpmlint
Consistent use of macros
No problems with it being noarch
Contains clean section
No directory ownership problems
Includes documentation

APPROVED

------- Additional Comments From rpm at greysector.net  2006-09-19 20:27 EST -------
Looks like we both missed some missing BuildRequires. Anyway, fixed, built for
devel and FC-5 branch requested. Thanks for the review!

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.