[Bug 207079] Review Request: perl-Cache - The Cache interface

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Cache -  The Cache interface


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=207079


cweyl at alumni.drew.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163778                      |163779
              nThis|                            |




------- Additional Comments From cweyl at alumni.drew.edu  2006-09-20 00:52 EST -------
Auto-requires misses a dep on perl(Tie::Hash) due to a use base construct, but
Tie::Hash is a core module.

There are three missing BR's, listed below.  For the purposes of this review,
I'm assuming they're in there (and added them).

+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written and uses macros consistently.
+ dist tag is present.
+ build root is correct.
+ license field matches the actual license.
+ license is open source-compatible.  License text not included upstream
+ source files match upstream:
 c64b8dd8f04e101bd20cde0c7c2e3d17  Cache-2.04.tar.gz
 c64b8dd8f04e101bd20cde0c7c2e3d17  Cache-2.04.tar.gz.srpm
+ latest version is being packaged.
X BuildRequires are proper.

    Date::Parse         => 2.24,
    Heap::Fibonacci     => 0.01,
    Digest::SHA1        => 2.01,

O builds in mock, with additional br's added.
+ rpmlint is silent.
O final provides and requires are sane:
** perl-Cache-2.04-1.fc5.noarch.rpm
== rpmlint
== provides
perl(Cache) = 2.04
perl(Cache::Entry) = 2.04
perl(Cache::File) = 2.04
perl(Cache::File::Entry) = 2.04
perl(Cache::File::Handle)
perl(Cache::File::Heap) = 2.04
perl(Cache::IOString)
perl(Cache::Memory) = 2.04
perl(Cache::Memory::Entry) = 2.04
perl(Cache::Memory::HeapElem)
perl(Cache::Null) = 2.04
perl(Cache::Null::Entry) = 2.04
perl(Cache::RemovalStrategy) = 2.04
perl(Cache::RemovalStrategy::FIFO)
perl(Cache::RemovalStrategy::LRU)
perl(Cache::Tester) = 2.04
perl-Cache = 2.04-1.fc5
== requires
perl >= 0:5.006
perl(:MODULE_COMPAT_5.8.8)
perl(Cache)
perl(Cache::File)
perl(Cache::File::Entry)
perl(Cache::File::Heap)
perl(Cache::IOString)
perl(Cache::Memory)
perl(Cache::Memory::Entry)
perl(Cache::Memory::HeapElem)
perl(Cache::Null::Entry)
perl(Carp)
perl(DB_File)
perl(Date::Parse)
perl(Digest::SHA1)
perl(Exporter)
perl(Fcntl)
perl(File::NFSLock)
perl(File::Path)
perl(File::Spec)
perl(File::Temp)
perl(Heap::Elem)
perl(Heap::Fibonacci)
perl(IO::File)
perl(IO::String)
perl(Storable)
perl(Symbol)
perl(Test::More)
perl(base)
perl(fields)
perl(strict)
perl(vars)
perl(warnings)
perl(warnings::register)
+ no shared libraries are present.
+ package is not relocatable.
+ owns the directories it creates.
+ doesn't own any directories it shouldn't.
+ no duplicates in %files.
+ file permissions are appropriate.
+ %clean is present.
+ %check is present and all tests pass:
 All tests successful.
 Files=11, Tests=590, 25 wallclock secs ( 2.10 cusr +  1.24 csys =  3.34 CPU)
+ no scriptlets present.
+ code, not content.
+ documentation is small, so no -docs subpackage is necessary.
+ %docs are not necessary for the proper functioning of the package.
+ no headers.
+ no pkgconfig files.
+ no libtool .la droppings.
+ not a GUI app.
+ not a web app.

APPROVED, provided the missing BR's are added.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.