[Bug 207761] Review Request: xpdf - A PDF file viewer for the X Window System

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xpdf - A PDF file viewer for the X Window System


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=207761


pertusus at free.fr changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pertusus at free.fr




------- Additional Comments From pertusus at free.fr  2006-09-23 05:36 EST -------
* I haven't tested, but it seems to me that the configure.in patch
  and autoconf call could be replaced by 
--without-Xp-library

* Why isn't t1lib used? 

* There are some rpmlint errors/warning, most of them should be
  sorted out easily:

E: xpdf tag-not-utf8 %changelog
E: xpdf non-utf8-spec-file xpdf.spec
W: xpdf mixed-use-of-spaces-and-tabs
E: xpdf tag-not-utf8 %changelog
E: xpdf obsolete-not-provided xpdf-chinese-simplified
E: xpdf obsolete-not-provided xpdf-chinese-traditional
E: xpdf obsolete-not-provided xpdf-korean
E: xpdf obsolete-not-provided xpdf-japanese
W: xpdf-utils summary-ended-with-dot Command line utilities for converting PDF
files.
E: xpdf-utils tag-not-utf8 %changelog
E: xpdf-debuginfo tag-not-utf8 %changelog

* It seems to me that the .png icon should better be in 
/usr/share/icons/hicolor/48x48/apps/
  with the appropriate calls to the gtk cache snippet.

* The calls to update-desktop-database are missing although
  there is a mimetype entry.

* The desktop-file-install vendor should be fedora.

* It seems to me that it should be xpdf-utils that requires
  poppler-utils.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.