[Bug 207798] Review Request: perl-Test-File - Test file attributes

bugzilla at redhat.com bugzilla at redhat.com
Sat Sep 23 15:03:39 UTC 2006


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Test-File - Test file attributes


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=207798


tibbs at math.uh.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163778                      |163779
              nThis|                            |




------- Additional Comments From tibbs at math.uh.edu  2006-09-23 11:03 EST -------
* source files match upstream:
   8997fa36af7b22d81c221d5325b46930  Test-File-1.16.tar.gz
* package meets naming and packaging guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* build root is correct.
* license field matches the actual license.
* license is open source-compatible.  License text not included upstream.
* latest version is being packaged.
* BuildRequires are proper (BR: perl(Test::Builder) and
perl(Test::Builder::Tester) are unnecessary as they are part of the base Perl
package.)
* %clean is present.
* package builds in mock (development, x86_64).
* package installs properly
* rpmlint is silent.
* final provides and requires are sane:
   perl(Test::File) = 1.16
   perl-Test-File = 1.16-1.fc6
  =
   perl(:MODULE_COMPAT_5.8.8)
   perl(File::Spec)
   perl(Test::Builder)
   perl(base)
   perl(strict)
   perl(vars)
* %check is present and all tests pass:
   All tests successful, 5 subtests skipped.
   Files=9, Tests=63,  6 wallclock secs ( 5.35 cusr +  0.35 csys =  5.70 CPU)
   The five skipped subtests are expected.
* package is not relocatable.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.




More information about the Fedora-package-review mailing list