[Bug 206842] Review Request: seq24 - Real-time MIDI sequencer

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: seq24 - Real-time MIDI sequencer


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=206842





------- Additional Comments From gemi at bluewin.ch  2006-09-26 11:37 EST -------
* source files match upstream:
  b2c39dad73f803727c39c2e2e443ebdb  seq24-0.8.7.tar.gz
* package meets naming and packaging guidelines
* specfile is properly named, is cleanly written and uses macros consistently
* dist tag is present
* build root is correct
* license field matches the actual license
* license is open source-compatible, license text included in package
* latest version is being packaged
* BuildRequires are proper
* compiler flags are appropriate
* %clean is present
* package builds in mock (FC-5, i386)
* package installs properly
* rpmlint is silent
* final provides and requires are sane:
* package is not relocatable
* owns the directories it creates
* doesn't own any directories it shouldn't
* no duplicates in %files
* file permissions are appropriate
* scriptlets update icons cache
* code, not content
* documentation is small, so no -docs subpackage is necessary
* %docs are not necessary for the proper functioning of the package
* no headers
* no pkgconfig files
* no libtool .la droppings

I have two complaints:
1. I'd rather have the description in a non-personalized style. However
   you may do as you wish, it is not a blocker.
2. The dump command conflicts with the /sbin/dump command, although they
   are not in the same directory. I recommend renaming "dump" to "seq24-dump".
   The source code does not reference it, so this should suffice. Upstream
   should also be notified.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.