[Bug 207763] Review Request: ddd - GUI for several command-line debuggers

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ddd - GUI for several command-line debuggers


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=207763





------- Additional Comments From pertusus at free.fr  2006-09-26 18:41 EST -------
Some issues with that package (some are blockers, other are 
minor but most are serious):

* spec should be utf8 encoded

* missing Requires for proper functionning:
gdb, /usr/bin/xfontsel, xterm, gnuplot
and an html viewer, I propose htmlview

* html viewing (in Help->DDD WWW Page) is broken for me, since 
  konqueror is used but incorrectly called. a possible fix
  would be to Requires: htmlview, and then make a patch such that
  in the installed Ddd file in /usr/share/ddd-3.3.11/ddd/Ddd
  there is

Ddd*wwwCommand: \
   htmlview @URL@

  instead of the default broken list

* desktop category X-Red-Hat-Extra should be removed 

* Many interesting files missing from %docs. 

* instead of patching configure.ac and rerunning autotools
  (and doing it implicitly, wich is bad) a diff to 
  configure should be better. I attach a simple one.

* It seems to me that defaults come from Ddd.in, 
  currently installed at /usr/share/ddd-3.3.11/ddd/Ddd
  so the programs required by ddd 
  should be detected by ./configure, and therefore in 
  BuildRequires. gdb is a fallback, xterm is a fallback
  but the following are tested: xterm kterm dtterm hpterm
  xfontsel is the fallback. 

  You should make sure that builds are reproducible 
  even if additional packages are required for the buildrequires
  but at the same time you may also want to avoid unneeded
  buildrequires. You can even change the defaults, and even
  patch configure for their detection (and adapt Requires 
  asked above accordingly).

* /usr/share/ddd-3.3.11/ddd/Ddd is a config file. In the 
  INSTALL file, however, unless I didn't understood it
  right, it is warned against letting it under the user
  control because it may change between version. I don't
  have a firm opinion on that subject. Maybe it could be
  left where it is and flagged with %config? maybe it 
  could be moved to %_sysconfdir, but not to the app-default
  dir? 
  (it seems to be find by ddd/resources.C:
   static string own_app_defaults_file =
    resolvePath(string(ddd_NAME) + "/" + app_class);
  and if not there the standard X app-default file is tried).

  Maybe the best thing would be to do a directory in sysconfdir
  with %{name}-%{version} and put Ddd in it, and change the
  code such that resolvePath isn'called and instead a modified
  version that looks in HOME, then in sysconfdir/ddd-3.3.11/.

* it would be possible to BuildRequire readline-devel and
  pass --with flag to configure, I don't know the implications
  though.

* --disable-dependency-tracking could be passed to configure

I tried to have a look at theme stuff and vsl stuff, it
didn't seemed to work for me, but I am not a ddd user.
Maybe somebody who knows better ddd and vsl could have
a look at what is required to have that part work properly.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.