[Bug 205075] Review Request: fwbackups - a user backup program, with support for automated backups and on-demand backups

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: fwbackups - a user backup program, with support for automated backups and on-demand backups


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=205075





------- Additional Comments From tibbs at math.uh.edu  2006-09-30 00:20 EST -------
Sorry for taking so long to respond; work intruded a bit into my evenings.

Firstly, the Source0: URL is not valud; it looks like you need to downcase
"FWBackups".  However, after doing this I find that again the files are not the
same.  What's in the srpm needs to match precisely what is downloaded from the
web site.

Also, for your sanity I recommend something like:

Source0: http://www.diffingo.com/downloads/fwbackups/fwbackups-%{version}.tar.gz

so that you only have the update the version in one place when you update the
package.

Aside from that, you should clean up the commented lines in %install (and the
commented Provides as well).  And I wonder what you have your tabs set for,
since the indentation is all over the place on my screen.

The package installs fine and seems to work for me on FC5.  (I did not test
actually running a backup.)

So really it's down to the tarball actually matching what's at the upstream web
site, and a few minor specfile adjustments.

Review:
X source files match upstream.
* package meets naming and packaging guidelines.
X specfile is properly named, is cleanly written and uses macros consistently
(needs minor cleanups).
* dist tag is present.
* build root is correct.
* license field matches the actual license.
* license is open source-compatible.  License text included in package.
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (development & FC5, x86_64 & i386).
* package installs properly
* package runs OK.  (I only did some basic tests and didn't actually run a backup.)
* rpmlint is silent.
* final provides and requires are sane:
   config(fwbackups) = 1.42.1-1.fc6
   fwbackups = 1.42.1-1.fc6
  =
   /bin/bash
   /usr/bin/python
   config(fwbackups) = 1.42.1-1.fc6
   pygtk2
   pygtk2-libglade
   python(abi) = 2.4
   redhat-artwork
* %check is not present; no test suite upstream.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* GUI app; .desktop files are supplied and installed properly.  No mimetype
keys, so no need to run update-mime-database. 

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.