[Bug 196379] Review Request: kdeartwork-extras: Artwork Extras, including xscreensaver-based screensavers

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: kdeartwork-extras: Artwork Extras, including xscreensaver-based screensavers


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196379





------- Additional Comments From rdieter at math.unl.edu  2006-09-30 13:50 EST -------
> Does "sourc"ing Qt config files (/etc/profile.d/qt.sh) still needed?

Strictly speaking, no, not for mock anyway.  otoh, it's presence certainly is
not wrong nor does it cause any harm.

> Does this package (kdeartwork-extras) really require
> xscreensaver related packages?

Yes, most of the bundled screensavers actually use xscreensaver as the backend.

> It is someting like
>    "optional", isn't it? Perhaps there are some users
>    who don't want to install xscreensaver-gl-extras.

Without more package splitting, no.  The manual work required to make that work
properly simply isn't worth it, imo.

>   - Is xscreensaver-base really required?

Yes.  %%configure checks for the presence of the xscreensaver bits at buildtime.

>    * Desktop files corresponding to the following hacks are missing

Personally, I'm not interested in adding those by hand.  IMO, it's an upstream
issue (ie, I'd prefer to let them "fix" it).

>    * IMO, the hacks in the following package can also be used for 
>     this package. 

I'll ping upstream about these too.

> W: kdeartwork-extras macro-in-%changelog _libdir
> W: kdeartwork-extras macro-in-%changelog _libexecdir
>   Use %% to avoild having macros expanded.

Oops, will fix that.



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.