PATCH Re: Firewire locking problem

[Jay Fenlason]

On Thu, Oct 11, 2007 at 10:30:22PM +0200, Stefan Richter wrote:
> Jay Fenlason wrote on 2007-10-08:
> > --- ../vanilla/drivers/firewire/fw-cdev.c	2007-07-08 19:32:17.000000000 -0400
> > +++ drivers/firewire/fw-cdev.c	2007-10-08 11:21:53.000000000 -0400
> > @@ -140,11 +140,10 @@ static void queue_event(struct client *c
> >  	event->v[1].size = size1;
> >  
> >  	spin_lock_irqsave(&client->lock, flags);
> > -
> >  	list_add_tail(&event->link, &client->event_list);
> > -	wake_up_interruptible(&client->wait);
> > -
> >  	spin_unlock_irqrestore(&client->lock, flags);
> > +
> > +	wake_up_interruptible(&client->wait);
> >  }
> >  
> >  static int
> 
> Committed to linux1394-2.6.git, with modified patch title and changelog:
> http://git.kernel.org/?p=linux/kernel/git/ieee1394/linux1394-2.6.git;a=commit;h=60a8fc669ed6fb8554166f675227ebc56ada975a
> 
> | firewire: fw-cdev: reorder wakeup vs. spinlock
> |
> | Signed-off-by: Jay Fenlason <fenlason at redhat.com>
> |
> | Prompted by https://bugzilla.redhat.com/show_bug.cgi?id=323411
> |
> | Signed-off-by: Stefan Richter <stefanr at s5r6.in-berlin.de>
> 
> Is this OK?

Looks fine to me.

			-- JF