[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [fedora-virt] [PATCH] add comments suggesting memory-handling improvements



Richard W.M. Jones wrote:

> On Wed, Jul 01, 2009 at 06:21:05PM +0200, Jim Meyering wrote:
>> I've include a patch below.  It would have been easier and cleaner *looking*
>> to use functions like xrealloc, xstrdup, etc. that exit upon failure here.
>> But since nothing else seems to exit from this code, I bit the bullet:
>> (this compiles, but "make check" hasn't completed yet)
>
> Yes, I agree.  There's not very much that guestfish can do if it runs
> out of memory, and the most sensible thing would be just to exit with
> an error (or abort).
>
>> Hmm... new test failures on F11 (details below)
>> But I'd just pulled latest and rebased, too.
>>
>> >From 77b4a54834cd3d3e6994508104334f501f5d99f1 Mon Sep 17 00:00:00 2001
>> From: Jim Meyering <meyering redhat com>
>> Date: Wed, 1 Jul 2009 16:09:33 +0200
>> Subject: [PATCH] fish: handle some out-of-memory conditions
>>
>> * fish/destpaths.c (xalloc_oversized): Define.
>> (complete_dest_paths_generator): Use size_t as type for a few
>> variables, rather than int.
>> Don't deref NULL or undef on failed heap alloc.
>> Don't leak on failed realloc.
>> Detect theoretical overflow when count_strings returns a very
>> large number of strings.
>> Handle asprintf failure.
>> (APPEND_STRS_AND_FREE): Rewrite as do {...}while(0), so that each use
>> can/must be followed by a semicolon.  Better for auto-formatters.
>> ---
>>  fish/destpaths.c |   91 ++++++++++++++++++++++++++++++++++++-----------------
>>  1 files changed, 62 insertions(+), 29 deletions(-)
>>
>> diff --git a/fish/destpaths.c b/fish/destpaths.c
>> index 6cddafa..90970de 100644
>> --- a/fish/destpaths.c
>> +++ b/fish/destpaths.c
>> @@ -1,5 +1,5 @@
>>  /* guestfish - the filesystem interactive shell
>> - * Copyright (C) 2009 Red Hat Inc.
>> + * Copyright (C) 2009 Red Hat Inc.
>
> Strange, this doesn't look like any change?

As I sent it, I accidentally let a write hook remove the trailing blank
on the "- ..." line.

I.e., that change (before being munged) removes the sole
trailing blank in that file.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]