[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [fedora-virt] [PATCH libguestfs] use xmalloc and xcalloc in generated code



On Fri, Jul 03, 2009 at 12:19:48AM +0200, Jim Meyering wrote:
> Richard W.M. Jones wrote:
> > I think the patch is fine, but I generally wonder why we now have
> > functions which do the same thing called xmalloc and
> > [guestfs_]safe_malloc?
> 
> I've adjusted to use only safe_malloc and safe_calloc,
> instead of xmalloc and xcalloc.  With this, rebased against
> the latest, all tests pass and duration is 20m, much better than
> the recent 33m, yet slightly worse than pre-virtio time of 15m.

This will probably be because of:
https://bugzilla.redhat.com/show_bug.cgi?id=509383#c3

> [the patch]

+1

Rich.

-- 
Richard Jones, Emerging Technologies, Red Hat  http://et.redhat.com/~rjones
virt-df lists disk usage of guests without needing to install any
software inside the virtual machine.  Supports Linux and Windows.
http://et.redhat.com/~rjones/virt-df/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]