Re: [fedora-virt] ksmtuned, v2

[Mark McLoughlin <markmc redhat com>]

On Wed, 2009-09-23 at 10:52 +0300, Dan Kenigsberg wrote:
> diff --git a/ksmtuned.init b/ksmtuned.init
> index 205531a..46332f8 100644
> --- a/ksmtuned.init
> +++ b/ksmtuned.init
> @@ -75,8 +75,11 @@ case "$1" in
>    condrestart)
>         condrestart
>         ;;
> +  retune)
> +        kill -SIGUSR1 `cat ${pidfile}`
> +        RETVAL=$?
>    *)
> -       echo $"Usage: $prog {start|stop|restart|condrestart|status|help}"
> +       echo $"Usage: $prog {start|stop|restart|condrestart|status|retune|help}"
>         RETVAL=3
>  esac

Unusually, I'm actually testing the stuff I'm building today and I hit:

/etc/init.d/ksmtuned: line 81: syntax error near unexpected token `)'
/etc/init.d/ksmtuned: line 81: `  *)'

Missing a ';;' in the handling of retune; fixed now

Cheers,
Mark.