Re: [Freeipa-devel] [PATCH] be clearer about what is being configured

[Rob Crittenden <rcritten redhat com>]

Martin Nagy wrote:
> Rob Crittenden wrote:
> > We always displayed this:
> >
> > This includes:
> >   * Configure the Network Time Daemon (ntpd)
> >
> > Even if -N was passed to not configure ntpd. So instead add a new list 
> > of excluded features.
> >
> > rob
>
> How about doing this for bind as well? And we could also customize the 
> end message telling the user what ports should be open. Plus, let the 
> message say "You must make sure" instead of "You may need to open".
>
> Martin

Revised patch with some suggestions from mnagy in #freeipa

rob

>From c581b9e77b154e7f9ac234ec4954159dd2df4ec4 Mon Sep 17 00:00:00 2001
From: Rob Crittenden <rcritten redhat com>
Date: Fri, 6 Jun 2008 15:25:36 -0400
Subject: [PATCH] Make it clear which packages are being configured and which aren't.

450175
---
 ipa-server/ipa-install/ipa-server-install |   18 +++++++++++++++---
 1 files changed, 15 insertions(+), 3 deletions(-)

diff --git a/ipa-server/ipa-install/ipa-server-install b/ipa-server/ipa-install/ipa-server-install
index 0123b4e..f5bf007 100644
--- a/ipa-server/ipa-install/ipa-server-install
+++ b/ipa-server/ipa-install/ipa-server-install
@@ -346,11 +346,18 @@ def main():
     print "This program will setup the FreeIPA Server."
     print ""
     print "This includes:"
-    print "  * Configure the Network Time Daemon (ntpd)"
+    if options.conf_ntp:
+        print "  * Configure the Network Time Daemon (ntpd)"
     print "  * Create and configure an instance of Directory Server"
     print "  * Create and configure a Kerberos Key Distribution Center (KDC)"
     print "  * Configure Apache (httpd)"
     print "  * Configure TurboGears"
+    if options.setup_bind:
+        print "  * Configure DNS (bind)"
+    if not options.conf_ntp:
+        print ""
+        print "Excluded by options:"
+        print "  * Configure the Network Time Daemon (ntpd)"
     print ""
     print "To accept the default shown in brackets, press the Enter key."
     print ""
@@ -532,14 +539,19 @@ def main():
     print "Setup complete"
     print ""
     print "Next steps:"
-    print "\t1. You may need to open some network ports - specifically:"
+    print "\t1. You must make sure these network ports are open:"
     print "\t\tTCP Ports:"
     print "\t\t  * 80, 443: HTTP/HTTPS"
     print "\t\t  * 389, 636: LDAP/LDAPS"
     print "\t\t  * 88, 464: kerberos"
+    if options.setup_bind:
+        print "\t\t  * 53: bind"
     print "\t\tUDP Ports:"
     print "\t\t  * 88, 464: kerberos"
-    print "\t\t  * 123: ntp"
+    if options.setup_bind:
+        print "\t\t  * 53: bind"
+    if options.conf_ntp:
+        print "\t\t  * 123: ntp"
     print ""
     print "\t2. You can now obtain a kerberos ticket using the command: 'kinit admin'"
     print "\t   This ticket will allow you to use the IPA tools (e.g., ipa-adduser)"
-- 
1.5.4

Attachment: smime.p7s
Description: S/MIME Cryptographic Signature