[Freeipa-devel] [PATCH] 1107 smartproxy cleanup

[Martin Kosek]

On 05/08/2014 07:38 PM, Nathaniel McCallum wrote:
> On Thu, 2014-05-08 at 13:36 -0400, Rob Crittenden wrote:
>> Nathaniel McCallum wrote:
>>> On Thu, 2014-05-08 at 09:12 -0400, Rob Crittenden wrote:
>>>> Rob Crittenden wrote:
>>>>> Rob Crittenden wrote:
>>>>>> Remove some unused files, fix an import which means we don't need to
>>>>>> import from ipaserver, fix up Requires so it should work better running
>>>>>> on a different box than the IPA server.
>>>>>
>>>>> Found and fixed a couple more minor issues.
>>>>
>>>> Fix one more issue. This sets the ipa client log to /dev/null to
>>>> suppress the error
>>>>
>>>> ipa: ERROR: Could not create log_dir u'/var/www/.ipa/log'
>>>
>>> What is the purpose of sending the bootstrap logs for smartproxy
>>> to /dev/null?
>>
>> It is all client logs. The smartproxy acts as an IPA client and clients 
>> log some things in ~/.ipa/log by default. We don't really want these 
>> logs in this case, it's logged anyway, and this suppresses the error by 
>> writing things to the bit bucket.
>>
>> The other way would be to add an option to not log but that seems like 
>> overkill.
> 
> That is all that stood out to me. ACK
> 
> Nathaniel

Pushed to master: 74412dbf88f78b19a54c35e326e173f5344922d0

Martin