[PATCH] Added firewall, partition, repo tests; Made minor changes to firewall, partition, repo commands.

Chris Lumens clumens at redhat.com
Wed Feb 11 20:24:05 UTC 2009


> Added checking of unexpected arguments, and raising a KickstartValueError, if they are given.
> Also edited some output strings formatting, to ensure there are no double spaces, if some of the values are missing.
> ---
>  pykickstart/commands/firewall.py  |   29 ++++++---
>  pykickstart/commands/partition.py |    2 +-
>  pykickstart/commands/repo.py      |    6 ++-
>  tests/commands/firewall.py        |   98 +++++++++++++++++++++++++++++
>  tests/commands/partition.py       |  124 +++++++++++++++++++++++++++++++++++++
>  tests/commands/repo.py            |   88 ++++++++++++++++++++++++++
>  6 files changed, 335 insertions(+), 12 deletions(-)
>  create mode 100644 tests/commands/firewall.py
>  create mode 100644 tests/commands/partition.py
>  create mode 100644 tests/commands/repo.py

Pushed.  Thanks for all the hard work.

- Chris




More information about the Kickstart-list mailing list