Re: [Libguestfs] daemon/ warnings

["Richard W.M. Jones" <rjones redhat com>]

On Mon, Aug 10, 2009 at 12:20:53PM +0200, Jim Meyering wrote:
> How's this?
> I nearly added _ATTRIBUTE or ATTRIBUTE_ to the new name,
> but that's pretty darn long, and seemed like overkill,
> considering it's only used in this one file.
> 
> +#if ! ENABLE_DEBUG_COMMAND
> +# define MAYBE_UNUSED ATTRIBUTE_UNUSED
> +#else
> +# define MAYBE_UNUSED /* empty */
> +#endif
> +
>  char *
> -do_debug (char *subcmd ATTRIBUTE_UNUSED, char **argv ATTRIBUTE_UNUSED)
> +do_debug (char *subcmd MAYBE_UNUSED, char **argv MAYBE_UNUSED)
>  {
>  #if ENABLE_DEBUG_COMMAND
>    int argc, i;

Looks good to me - ACK.

Rich.

-- 
Richard Jones, Emerging Technologies, Red Hat  http://et.redhat.com/~rjones
New in Fedora 11: Fedora Windows cross-compiler. Compile Windows
programs, test, and build Windows installers. Over 70 libraries supprt'd
http://fedoraproject.org/wiki/MinGW http://www.annexia.org/fedora_mingw