[Libguestfs] do_umount adjustment

Jim Meyering jim at meyering.net
Wed Aug 12 08:38:10 UTC 2009


Richard W.M. Jones wrote:
> On Wed, Aug 12, 2009 at 10:25:34AM +0200, Jim Meyering wrote:
>> If do_umount is the only case like that (and it seems to be),
>> a more local change is possible: if pathordevice starts with
>> /sysroot/dev, remove the "/sysroot" part.
>>
>> Not terribly pretty to add the prefix, and then to remove it
>> right afterwards, but...
>
> Ick.  Remember that "/sysroot" is not a constant.  It's the variables
> sysroot and sysroot_len that contain the actual prefix.

Yes, I know ;-)
Sounds like you too think this little bit of pragmatism is the lesser
of two evils.




More information about the Libguestfs mailing list