[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libguestfs] [PATCH libguestfs 9/9] fish/: enable -Werror and all of gcc's warning options



On Fri, Aug 21, 2009 at 03:28:19PM +0200, Jim Meyering wrote:
> From: Jim Meyering <meyering redhat com>
> 
> * fish/Makefile.am: Use $(WARN_CFLAGS) $(WERROR_CFLAGS).
> ---
>  fish/Makefile.am |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/fish/Makefile.am b/fish/Makefile.am
> index 5bf3fbd..94bf757 100644
> --- a/fish/Makefile.am
> +++ b/fish/Makefile.am
> @@ -51,8 +51,8 @@ BUILT_SOURCES = \
>  guestfish_CFLAGS = \
>  	-I$(top_srcdir)/src -I$(top_builddir)/src \
>  	-I$(top_srcdir)/fish -I$(top_builddir)/fish \
> -	-Wall \
> -	-DGUESTFS_DEFAULT_PATH='"$(libdir)/guestfs"'
> +	-DGUESTFS_DEFAULT_PATH='"$(libdir)/guestfs"' \
> +	$(WARN_CFLAGS) $(WERROR_CFLAGS)
> 
>  guestfish_LDADD = $(top_builddir)/src/libguestfs.la $(LIBREADLINE)
> 
> -- 
> 1.6.4.378.g88f2f

ACK (to the whole patch series).

Rich.

-- 
Richard Jones, Emerging Technologies, Red Hat  http://et.redhat.com/~rjones
libguestfs lets you edit virtual machines.  Supports shell scripting,
bindings from many languages.  http://et.redhat.com/~rjones/libguestfs/
See what it can do: http://et.redhat.com/~rjones/libguestfs/recipes.html


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]