Re: [Libvir] [PATCH 4/6] Inactive domain support: Ignore inactive domains

["Daniel P. Berrange" <berrange redhat com>]

On Wed, Nov 15, 2006 at 04:32:40PM +0000, Daniel P. Berrange wrote:
> On Wed, Nov 15, 2006 at 05:12:49AM -0500, Daniel Veillard wrote:
> > On Wed, Nov 15, 2006 at 02:23:23AM +0000, Daniel P. Berrange wrote:
> > > ***************
> > > *** 716,730 ****
> > >       int ret;
> > >   
> > >       if (!VIR_IS_CONNECTED_DOMAIN(domain)) {
> > > ! 	if (domain == NULL)
> > > ! 	    virProxyError(NULL, VIR_ERR_INVALID_DOMAIN, __FUNCTION__);
> > > ! 	else
> > > ! 	    virProxyError(domain->conn, VIR_ERR_INVALID_DOMAIN, __FUNCTION__);
> > > !         return (0);
> > >       }
> > >       if (info == NULL) {
> > >           virProxyError(domain->conn, VIR_ERR_INVALID_ARG, __FUNCTION__);
> > > ! 	return (-1);
> > >       }
> > >       memset(&req, 0, sizeof(req));
> > >       req.command = VIR_PROXY_DOMAIN_INFO;
> > > --- 718,734 ----
> > >       int ret;
> > >   
> > >       if (!VIR_IS_CONNECTED_DOMAIN(domain)) {
> > > !         if (domain == NULL)
> > > !             virProxyError(NULL, VIR_ERR_INVALID_DOMAIN, __FUNCTION__);
> > > !         else
> > > !             virProxyError(domain->conn, VIR_ERR_INVALID_DOMAIN, __FUNCTION__);
> > > !         return (-1);
> > 
> >    Agreed for the Proxy driver you now want to return -1 on Info if
> > it's not a connected domain. We already emitted an error there anyway
> > make sense, but I wonder why it used to return 0 there ... hum....
> 
> Just looks like a typo to me.
> 
> > > --- src/xend_internal.c	15 Nov 2006 02:34:04 -0000
> > > ***************
> > > *** 1266,1272 ****
> > >       return node;
> > >   }
> > >   
> > > ! static int
> > >   xend_get_config_version(virConnectPtr conn) {
> > >       struct sexpr *root;
> > >       const char *value;
> > > --- 1266,1272 ----
> > >       return node;
> > >   }
> > >   
> > > ! int
> > >   xend_get_config_version(virConnectPtr conn) {
> > >       struct sexpr *root;
> > >       const char *value;
> > 
> >   I assume exporting it is needed for other patches. Just check  :-)
> 
> Yeah, need to use it in xm_internal when generating the SEXPR to feed to
> Xend to start an inactive domain.

Now committed.

Dan.
-- 
|=- Red Hat, Engineering, Emerging Technologies, Boston.  +1 978 392 2496 -=|
|=-           Perl modules: http://search.cpan.org/~danberr/              -=|
|=-               Projects: http://freshmeat.net/~danielpb/               -=|
|=-  GnuPG: 7D3B9505   F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505  -=|