Re: [Libvir] PATCH: Fix paravirt FB with xm driver

[Daniel Veillard <veillard redhat com>]

On Fri, Aug 10, 2007 at 05:10:46PM +0100, Daniel P. Berrange wrote:
> On Fri, Aug 10, 2007 at 12:08:26PM -0400, Daniel Veillard wrote:
> > On Fri, Aug 10, 2007 at 04:39:03PM +0100, Daniel P. Berrange wrote:
> > > The code for dealing with the paravirt framebuffer was missing code to deal
> > > with an explicit vncdisplay=N  setting - only working for vncunused=1. It
> > > was also not flexible enough in processing the 2 different styles of FB
> > > config.
> > 
> >   I'm not sure I undertand the logic for setting the port, why going
> > whould xenstore there ?
> 
> I'm not sure what you mean - xenstore isn't involved in this. This is
> for taking the XML and writing out the /etc/xen config - the port stuff
> is basically making sure that port="5903" is translated into the config
> option 'vncdisplay=3'. Previously only port="-1"  was working.

Whoops reread, yeah, I don't understand why I saw a xenstore operation there !
weird ...
Okay +1

Daniel

-- 
Red Hat Virtualization group http://redhat.com/virtualization/
Daniel Veillard      | virtualization library  http://libvirt.org/
veillard redhat com  | libxml GNOME XML XSLT toolkit  http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine  http://rpmfind.net/