[Libvir] Re: [PATCH 3/7] Add option to pass stdin fd to virExec

[Daniel Veillard <veillard redhat com>]

On Mon, Aug 13, 2007 at 12:55:01PM +0100, Daniel P. Berrange wrote:
> On Mon, Aug 13, 2007 at 06:01:42AM -0400, Daniel Veillard wrote:
> > On Sun, Aug 12, 2007 at 07:11:35PM -0400, Jim Paris wrote:
> > > If nonzero, uses the supplied fd instead of /dev/null.
> > > Update callers accordingly.
> > 
> >   Looks fine to me, we already have stdout and stderr, it's sensible. +1
> 
> Looks OK, but shouldn't we use -1 as the magic value here, since 0 is also
> a valid file descriptor.

  ohh, right, good catch ! +1 with that change,

Daniel

-- 
Red Hat Virtualization group http://redhat.com/virtualization/
Daniel Veillard      | virtualization library  http://libvirt.org/
veillard redhat com  | libxml GNOME XML XSLT toolkit  http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine  http://rpmfind.net/