Re: [Libvir] [PATCH] Block device and network stats (version 2)

[Daniel Veillard <veillard redhat com>]

On Tue, Aug 21, 2007 at 12:55:19PM +0100, John Levon wrote:
> On Tue, Aug 21, 2007 at 03:37:41AM +0100, Daniel P. Berrange wrote:
> 
> > The Xen impl as coded only works for disks named xvdN, because the code for
> > calculating device ID assumes xvdN device numbering scheme:
> > 
> >     device = 202 * 256 + minor;
> 
> What's with device numbering at all? Must we really repeat this crazy
> Linuxism from xend in libvirt :(

  Do you have an alternative ? Because this is commited in CVS and I 
would like to get 0.3.2 rolled out ASAP ! So if you have a practical
suggestion or a patch, please post it, I may delay the issue but
just stating 'crazy Linuxism' without specifying why and how this can
be fixed won't help.

  thanks !

Daniel

-- 
Red Hat Virtualization group http://redhat.com/virtualization/
Daniel Veillard      | virtualization library  http://libvirt.org/
veillard redhat com  | libxml GNOME XML XSLT toolkit  http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine  http://rpmfind.net/