Re: [Libvir] [PATCH] TX/RX network stats are swapped

[Daniel Veillard <veillard redhat com>]

On Wed, Aug 29, 2007 at 02:11:16PM +0100, Richard W.M. Jones wrote:
> I noticed that the stats reported by virDomainInterfaceStats appeared to 
> be swapped around.  If the domain was downloading a lot of information, 
> then tx_bytes would increase quickly (I'd expect rx_bytes to increase 
> more if the domain was downloading).

  Dohh, +1

> The problem is that xen_internal.c measures the TX/RX from the point of 
> view of dom0.  So that if dom0 is TRANSMITTING a lot of data up to the 
> domain, then that domain is really RECEIVING it.
> 
> Yes, I feel like an idiot ...

  Well nobody noticed it before, by review or running it, the blame is shared !

Daniel

-- 
Red Hat Virtualization group http://redhat.com/virtualization/
Daniel Veillard      | virtualization library  http://libvirt.org/
veillard redhat com  | libxml GNOME XML XSLT toolkit  http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine  http://rpmfind.net/