Re: [Libvir] [PATCH] Fix escaping of '<' in virBufferEscapeString

[Daniel Veillard <veillard redhat com>]

On Wed, Dec 12, 2007 at 03:40:19PM +0000, Richard W.M. Jones wrote:
> < is currently escaped as &ll;
> 
> I'm guessing it should be &lt;
[...]
> -- 
> Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/
> Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod
> Street, Windsor, Berkshire, SL4 1TE, United Kingdom.  Registered in
> England and Wales under Company Registration No. 03798903

> Index: src/buf.c
> ===================================================================
> RCS file: /data/cvs/libvirt/src/buf.c,v
> retrieving revision 1.7
> diff -u -r1.7 buf.c
> --- src/buf.c	11 Dec 2007 21:57:29 -0000	1.7
> +++ src/buf.c	12 Dec 2007 15:38:46 -0000
> @@ -222,7 +222,7 @@
>          if (*cur == '<') {
>  	    *out++ = '&';
>  	    *out++ = 'l';
> -	    *out++ = 'l';
> +	    *out++ = 't';
>  	    *out++ = ';';
>  	} else if (*cur == '>') {
>  	    *out++ = '&';

  Dohh !!!

  +1

Daniel

-- 
Red Hat Virtualization group http://redhat.com/virtualization/
Daniel Veillard      | virtualization library  http://libvirt.org/
veillard redhat com  | libxml GNOME XML XSLT toolkit  http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine  http://rpmfind.net/