Re: [Libvir] PATCH: Compatability with Xen 3.2.0

[John Levon <levon movementarian org>]

On Mon, Dec 17, 2007 at 07:19:04PM +0000, Daniel P. Berrange wrote:

> In Xen 3.2.0 the  physinfo hypercall was changed to remove the field
> 'sockets_per_node' and add in 'nr_cpus'. We use the sockets_per_node field
> in livirt for the  virNodeInfo struct :-(  This patch re-calculates its
> value in terms of 'nr_cpus / (nodes*cores*threads)' which is how older
> Xen used to figure it out.

I thought the whole point of that change was that the value was not
correct in some cases? I admit I don't know what those cases were, but
isn't this just re-introducing that incorrect information?

regards
john