Re: [Libvir] [patch 3/9] Dont share virConnect->handle between xen and qemu

["Richard W.M. Jones" <rjones redhat com>]

markmc redhat com wrote:
> Don't share virConnect->handle with the xen hypervisor socket so
> that we can have a qemud connection open at the same time as a
> xen hypervisor connection.
>
> Signed-off-by: Mark McLoughlin <markmc redhat com>
>
> Index: libvirt-foo/src/internal.h
> ===================================================================
> --- libvirt-foo.orig/src/internal.h	2007-01-23 14:39:45.000000000 +0000
> +++ libvirt-foo.orig/src/internal.h	2007-01-23 14:39:45.000000000 +0000
> @@ -117,6 +117,8 @@ struct _virConnect {
>      struct sockaddr_un addr_un;     /* the unix address */
>      struct sockaddr_in addr_in;     /* the inet address */
>  
> +    int qemud_fd;           /* connection to qemud */
> +
>      /* error stuff */
>      virError err;           /* the last error */
>      virErrorFunc handler;   /* associated handlet */
> Index: libvirt-foo/src/qemu_internal.c
> ===================================================================
> --- libvirt-foo.orig/src/qemu_internal.c	2007-02-14 01:40:09.000000000 +0000
> +++ libvirt-foo.orig/src/qemu_internal.c	2007-02-14 01:40:09.000000000 +0000
> @@ -244,7 +244,7 @@ qemuOpenClientUNIX(virConnectPtr conn, c
>          return (-1);
>      }
>  
> -    conn->handle = fd;
> +    conn->qemud_fd = fd;

I don't really understand this patch.  Surely if you want to connect to 
the Xen h/v and qemud you'd use two separate connections?

Rich.

--
Emerging Technologies, Red Hat  http://et.redhat.com/~rjones/
64 Baker Street, London, W1U 7DF     Mobile: +44 7866 314 421
 "[Negative numbers] darken the very whole doctrines of the equations
 and make dark of the things which are in their nature excessively
 obvious and simple" (Francis Maseres FRS, mathematician, 1759)