Re: [Libvir] [PATCH]Guard for Dom0 by virsh domain stop commands

[Daniel Veillard <veillard redhat com>]

On Thu, Feb 22, 2007 at 07:08:01PM +0900, Kazuki　Mizushima wrote:
> Hi, Dan
> 
> Thank you for your reply, I understand you.
> I remake the patch.
> 
> Signed-off-by: Kazuki Mizushima <mizushima kazuk jp fujitsu com>
> 
> Thanks
> Kazuki Mizushima
> 
> Index: xs_internal.c (libvirt-0.2.0)
> ------------------------------------
> --- xs_internal.c       2007-02-22 18:35:19.000000000 +0900
> +++ xs_internal.c_guard2        2007-02-22 18:35:51.000000000 +0900
> @@ -631,7 +631,7 @@ xenStoreDomainShutdown(virDomainPtr doma
>                         __FUNCTION__);
>         return(-1);
>     }
> -    if (domain->id == -1)
> +    if (domain->id == -1 || domain->id == 0)
>         return(-1);
>     /*
>      * this is very hackish, the domU kernel probes for a special
> @@ -659,7 +659,7 @@ xenStoreDomainReboot(virDomainPtr domain
>                         __FUNCTION__);
>         return(-1);
>     }
> -    if (domain->id == -1)
> +    if (domain->id == -1 || domain->id == 0)
>         return(-1);
>     /*
>      * this is very hackish, the domU kernel probes for a special
> 

  Sounds good (I would just fully parenthesize the boolean expressions)
I can't apply it myself at the moment, but I guess Dan or Mark can do it :-)

  thanks !

Daniel

-- 
Red Hat Virtualization group http://redhat.com/virtualization/
Daniel Veillard      | virtualization library  http://libvirt.org/
veillard redhat com  | libxml GNOME XML XSLT toolkit  http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine  http://rpmfind.net/