Re: [Libvir] [PATCH] virsh Range check in Credit Scheduler

[Atsushi SAKAI <sakaia jp fujitsu com>]

Hi, Daniel

 uint16(weight and cap) is copyied in src/virsh.c
so It cannot rewrite on src/xen_internal.c.

Thanks
Atsushi SAKAI


Daniel Veillard <veillard redhat com> wrote:

> On Tue, Jul 17, 2007 at 11:16:24AM +0100, Richard W.M. Jones wrote:
> > Atsushi SAKAI wrote:
> > >Hi,
> > >
> > >Add Range check in Credit Scheduler.
> 
>   Hum, it's true that this code is really specific to Xen at this
> point in virsh.c 
>   But I think the long term way is to add that check where it can really be
> done without adding more hypervisor specific code to virsh.c, could you 
> rewrite the patch to actually make the check where it belongs in
> xenHypervisorSetSchedulerParameters() in src/xen_internal.c, that way
> not only virsh is protected but also any other app using the API to
> do scheduling tuning,
> 
>   thanks in advance,
> 
> Daniel
> 
> -- 
> Red Hat Virtualization group http://redhat.com/virtualization/
> Daniel Veillard      | virtualization library  http://libvirt.org/
> veillard redhat com  | libxml GNOME XML XSLT toolkit  http://xmlsoft.org/
> http://veillard.com/ | Rpmfind RPM search engine  http://rpmfind.net/