[Date Prev][Date Next] [Thread Prev][Thread Next]
[Thread Index]
[Date Index]
[Author Index]
Re: [Libvir] [PATCH] Fix strange error message in virsh attach-device
- From: Daniel Veillard <veillard redhat com>
- To: Masayuki Sunou <fj1826dm aa jp fujitsu com>
- Cc: libvir-list redhat com
- Subject: Re: [Libvir] [PATCH] Fix strange error message in virsh attach-device
- Date: Mon, 4 Jun 2007 04:43:39 -0400
On Mon, Jun 04, 2007 at 05:30:01PM +0900, Masayuki Sunou wrote:
> Hi Daniel
>
> Thank you for your comment.
>
> This patch changes about the following points.
>
> > buf.use = 0 means we are using 0 bytes of the buffer. That's the semantic
> > of buffer usage, if you really want to make it zero terminated, just use
> > buf.content[0] = 0;
> >
> 1. This patch initializes the data with "buf.content[0] = 0".
>
> > use buf->use instead of strlen(buf.content)
> >
> 2. This patch checks the data size with "buf->use".
Cool, thanks a lot !
Applied and commited to CVS,
thanks again,
Daniel
--
Red Hat Virtualization group http://redhat.com/virtualization/
Daniel Veillard | virtualization library http://libvirt.org/
veillard redhat com | libxml GNOME XML XSLT toolkit http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/
[Date Prev][Date Next] [Thread Prev][Thread Next]
[Thread Index]
[Date Index]
[Author Index]