Re: [Libvir] Add scheduler patch?

[Daniel Veillard <veillard redhat com>]

On Tue, Jun 05, 2007 at 07:42:31PM +0900, Atsushi SAKAI wrote:
> Hi, Daniel
> 
> Thank you for reviewing.
> 
> About xenHypervisorSetSchedulerParameters() in case of credit scheduler.
> I just set not changed parameter at first.
> I guess no problem on this.
> Any problem?
> 
> +            /* credit scheduler parameters 
> +             * following values do not change the parameters 
> +             */
> +            op_dom.u.getschedinfo.u.credit.weight = 0;
> +            op_dom.u.getschedinfo.u.credit.cap    = (uint16_t)~0U;

  yes I have seen that, but I wonder what happens when only one parameter
is not 0, does the hypercall set only that parameter ?
That does no prevent pushing that first version but that something which 
should be double checked to avoid catastrophic behaviour on edge cases.

Daniel

-- 
Red Hat Virtualization group http://redhat.com/virtualization/
Daniel Veillard      | virtualization library  http://libvirt.org/
veillard redhat com  | libxml GNOME XML XSLT toolkit  http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine  http://rpmfind.net/