[Libvir] PATCH: Fix marshalling of ID on wire with remote

Daniel P. Berrange berrange at redhat.com
Sun Jun 17 21:46:05 UTC 2007


THe code which marshalls virDomainptr objects onto the wire in the remote
driver forgets to include the 'id' value. We get away with this for Xen
and QEMU because they do most things based off name or UUID. The test
driver however wants the ID number. The attached patch fixes this


Dan
-- 
|=- Red Hat, Engineering, Emerging Technologies, Boston.  +1 978 392 2496 -=|
|=-           Perl modules: http://search.cpan.org/~danberr/              -=|
|=-               Projects: http://freshmeat.net/~danielpb/               -=|
|=-  GnuPG: 7D3B9505   F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505  -=| 
-------------- next part --------------
diff -r f1d50156f9a8 src/remote_internal.c
--- a/src/remote_internal.c	Sun Jun 17 16:27:46 2007 -0400
+++ b/src/remote_internal.c	Sun Jun 17 17:37:24 2007 -0400
@@ -1357,6 +1357,7 @@ remoteDomainGetInfo (virDomainPtr domain
     info->memory = ret.memory;
     info->nrVirtCpu = ret.nr_virt_cpu;
     info->cpuTime = ret.cpu_time;
+
     return 0;
 }
 
@@ -2440,6 +2441,7 @@ static void
 static void
 make_nonnull_domain (remote_nonnull_domain *dom_dst, virDomainPtr dom_src)
 {
+    dom_dst->id = dom_src->id;
     dom_dst->name = dom_src->name;
     memcpy (dom_dst->uuid, dom_src->uuid, VIR_UUID_BUFLEN);
 }


More information about the libvir-list mailing list