[Libvir] PATCH 5/9: Adapt to virError API
Daniel P. Berrange
berrange at redhat.com
Mon Jun 18 12:55:27 UTC 2007
On Mon, Jun 18, 2007 at 01:53:18PM +0100, Richard W.M. Jones wrote:
> Daniel P. Berrange wrote:
> >And with the actual patch...
> >
> >On Mon, Jun 18, 2007 at 03:18:40AM +0100, Daniel P. Berrange wrote:
> >>This patch switches the driver.c, conf.c and dispatch.c files over to use
> >>the virError object and associated API instead of a custom version.
>
> I don't know if I like this ...
>
> >+extern void __virRaiseError(virConnectPtr conn,
> >+ virDomainPtr dom,
> >+ virNetworkPtr net,
> >+ int domain,
> >+ int code,
> >+ virErrorLevel level,
> >+ const char *str1,
> >+ const char *str2,
> >+ const char *str3,
> >+ int int1, int int2, const char *msg, ...)
> >+ ATTRIBUTE_FORMAT(printf, 12, 13);
>
> although I can see why you did it. Would it be better to move the
> prototype of __virRaiseError out of src/internal.h and into
> include/libvirt/virterror.h? We declare and export other __internal
> symbols already.
This is a temporary hack. Once the QEMU code moves into the src/ directory
this duplicated declaration will go away again.
Regards,
Dan.
--
|=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=|
|=- Perl modules: http://search.cpan.org/~danberr/ -=|
|=- Projects: http://freshmeat.net/~danielpb/ -=|
|=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|
More information about the libvir-list
mailing list