Re: [Libvir] [PATCH] Add support for scheduler functions in remote

["Daniel P. Berrange" <berrange redhat com>]

On Fri, Jun 22, 2007 at 12:33:59PM +0100, Richard W.M. Jones wrote:
> This is a rather tedious patch, but I've tested it against the Xen 
> driver and it works for getting and setting the various parameters and 
> scheduler type.


Looks good to me, except for two calls to strdup which don't report
errors on ENOMEM.

> +        args.params.params_val[i].field = strdup (params[i].field);

Regards,
Dan.
-- 
|=- Red Hat, Engineering, Emerging Technologies, Boston.  +1 978 392 2496 -=|
|=-           Perl modules: http://search.cpan.org/~danberr/              -=|
|=-               Projects: http://freshmeat.net/~danielpb/               -=|
|=-  GnuPG: 7D3B9505   F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505  -=|