Re: [Libvir] [PATCH] Fix virDomainGetVcpus in the remote case

[Daniel Veillard <veillard redhat com>]

On Fri, Jun 22, 2007 at 04:25:25PM +0100, Richard W.M. Jones wrote:
> I wasn't copying enough data in the cpumaps parameter.  This fixes that 
> bug ...

  Looks fine, but maybe the error message need to be updated:

-    if (maplen > REMOTE_CPUMAPS_MAX) {                                         
+    if (maxinfo * maplen > REMOTE_CPUMAPS_MAX) {                               
         error (domain->conn, VIR_ERR_RPC, "maplen > REMOTE_CPUMAPS_MAX");


Daniel

-- 
Red Hat Virtualization group http://redhat.com/virtualization/
Daniel Veillard      | virtualization library  http://libvirt.org/
veillard redhat com  | libxml GNOME XML XSLT toolkit  http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine  http://rpmfind.net/