[Date Prev][Date Next] [Thread Prev][Thread Next] [Thread Index] [Date Index] [Author Index]

Re: [Libvir] [PATCH] export virConf* symbols (second version)

From: "Richard W.M. Jones" <rjones redhat com>
To: Mark McLoughlin <markmc redhat com>
Cc: libvir-list <libvir-list redhat com>
Subject: Re: [Libvir] [PATCH] export virConf* symbols (second version)
Date: Thu, 01 Mar 2007 13:58:35 +0000

Mark McLoughlin wrote:

Hi Rich,

On Wed, 2007-02-28 at 17:33 +0000, Richard W.M. Jones wrote:

+#define virConfNew() (_virConfNew())


	I wouldn't bother doing this, it just adds confusion - e.g. it helps to
know that the symbol is private from the calling site too, so just use
_virConfNew() everywhere ...

	Also suggest surrounding everything with:

#ifdef LIBVIRT_PRIVATE_API_DO_NOT_USE

	in src/conf.h (even though it's not installed) so that people have no
excuse if they use this ...

Thanks Mark. I'll put up a third version later (probably tomorrow infact, I'm building & fixing computers today).


Rich.

References:
- Re: [Libvir] [PATCH] export virConf* symbols (second version)
  - From: Mark McLoughlin

[Date Prev][Date Next] [Thread Prev][Thread Next] [Thread Index] [Date Index] [Author Index]