[Date Prev][Date Next] [Thread Prev][Thread Next]
[Thread Index]
[Date Index]
[Author Index]
Re: [Libvir] [PATCH] lots of warnings removed - libvirt can now compile with -Werror
- From: Mark McLoughlin <markmc redhat com>
- To: "Richard W.M. Jones" <rjones redhat com>
- Cc: libvir-list <libvir-list redhat com>
- Subject: Re: [Libvir] [PATCH] lots of warnings removed - libvirt can now compile with -Werror
- Date: Mon, 05 Mar 2007 09:18:49 +0000
Hi Rich,
Good stuff, looks fine to commit to me.
Just a nitpick:
On Fri, 2007-03-02 at 15:00 +0000, Richard W.M. Jones wrote:
> - activeNames = vshMalloc(ctl, sizeof(int) * maxactive);
> + activeNames = vshMalloc(ctl, sizeof (char *) * maxactive);
^
> - qsort(&activeNames[0], maxactive, sizeof(int), namesorter);
> + qsort(activeNames, maxactive, sizeof (char *), namesorter);
^
Extra whitespace here ...
Cheers,
Mark.
[Date Prev][Date Next] [Thread Prev][Thread Next]
[Thread Index]
[Date Index]
[Author Index]